laser engraves and rewrites fountain pen flavor + adds detailed lore #3796
Conversation
|
You currently have a negative Fix/Feature pull request delta of -21. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
🖕 |
Hopekz
changed the title
Hopekz
changed the title
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
🖕 |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Co-authored-by: harryob <[email protected]>
|
Might reopen this in the future when CM dev picks back up closer to how it was when I started. (turnaround back to 3-4 days) Personally for me it is a bit mentally exhausting at the moment to be open to modify something for a month so assuming I haven't moved on to another project I'll reopen this when I come back to CM dev. |
|
On second review this one is probably fine too |
Co-authored-by: harryob <[email protected]>
|
Your Fix/Feature pull request is currently below zero (-26). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
I've received a lot of positive feedback for this pen so since it is semi-important now I went ahead and took the time to get out some extended lore for this item and re-did the original description flavor text now that I decided it was made by ARMAT.
To-do maybe :
Update
There is now a laser engraving on the owner of the pen. Here is how that looks in-game:
🆑 Hopek
add: Changed the description flavortext of the fountain pen to match the new lore. There is now a laser engraving of the owner on the pen itself.
add: Added a detailed lore description for the fountain pen.
/:cl: